Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/core/inspector/DOMEditor.cpp

Issue 335583003: Remove unnecessary .get() in DOMEditor::ReplaceChildNodeAction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/DOMEditor.cpp
diff --git a/Source/core/inspector/DOMEditor.cpp b/Source/core/inspector/DOMEditor.cpp
index 6e986223e355ed4199ee5af82bd87acec47ea655..5c6d5ae45aba959701985691a37350feb9ec76d1 100644
--- a/Source/core/inspector/DOMEditor.cpp
+++ b/Source/core/inspector/DOMEditor.cpp
@@ -350,17 +350,13 @@ public:
virtual bool undo(ExceptionState& exceptionState) OVERRIDE
{
- // FIXME: Oilpan: The first .get() is unnecessary if m_oldNode is a
- // Persistent or a Member.
- m_parentNode->replaceChild(m_oldNode.get(), m_newNode.get(), exceptionState);
+ m_parentNode->replaceChild(m_oldNode, m_newNode.get(), exceptionState);
return !exceptionState.hadException();
}
virtual bool redo(ExceptionState& exceptionState) OVERRIDE
{
- // FIXME: Oilpan: The first .get() is unnecessary if m_newNode is a
- // Persistent or a Member.
- m_parentNode->replaceChild(m_newNode.get(), m_oldNode.get(), exceptionState);
+ m_parentNode->replaceChild(m_newNode, m_oldNode.get(), exceptionState);
return !exceptionState.hadException();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698