Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 335533002: API changes to Write path Session on down for FEC protection. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Jana, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

API changes to Write path Session on down for FEC protection. Added |fec_protection| flag to data writes to QuicSession and subclasses, down to QuicConnection and QuicPacketGenerator. This flag is used by the packet generator to turn on FEC protection for the flagged data. Merge internal change: 68993204 R=jri@chromium.org, rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -267 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 11 chunks +74 lines, -42 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_generator.h View 3 chunks +3 lines, -9 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 28 chunks +82 lines, -76 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 14 chunks +28 lines, -28 lines 0 comments Download
D net/quic/test_tools/quic_packet_generator_peer.h View 1 chunk +0 lines, -36 lines 0 comments Download
D net/quic/test_tools/quic_packet_generator_peer.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 6 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-12 02:57:06 UTC) #1
Jana
lgtm
6 years, 6 months ago (2014-06-12 18:07:23 UTC) #2
Ryan Hamilton
6 years, 6 months ago (2014-06-12 22:14:46 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698