Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: net/quic/quic_packet_generator.h

Issue 335533002: API changes to Write path Session on down for FEC protection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_generator.h
diff --git a/net/quic/quic_packet_generator.h b/net/quic/quic_packet_generator.h
index e9c773b910ae3dd2ea2a4b97ffe08c82aa02d528..e5b8de4d3fc97d8bcf84017607cfb31e9749c6d0 100644
--- a/net/quic/quic_packet_generator.h
+++ b/net/quic/quic_packet_generator.h
@@ -122,6 +122,7 @@ class NET_EXPORT_PRIVATE QuicPacketGenerator {
const IOVector& data,
QuicStreamOffset offset,
bool fin,
+ FecProtection fec_protection,
QuicAckNotifier* notifier);
// Indicates whether batch mode is currently enabled.
@@ -150,14 +151,6 @@ class NET_EXPORT_PRIVATE QuicPacketGenerator {
// creator, in which case, only the generator's state is altered.
void MaybeStartFecProtection();
- // Turn off FEC protection for subsequent packets. If |force| is true,
- // force-closes any open FEC group, sends out an FEC packet if one was under
- // construction, and turns off protection in the generator and creator. If
- // |force| is false, does the same as above if the creator is ready to send
- // and FEC packet. Note that when |force| is false, the creator may still have
- // an open FEC group after this method runs.
- void MaybeStopFecProtection(bool force);
-
// Serializes and calls the delegate on an FEC packet if one was under
// construction in the creator. When |force| is false, it relies on the
// creator being ready to send an FEC packet, otherwise FEC packet is sent
@@ -189,7 +182,8 @@ class NET_EXPORT_PRIVATE QuicPacketGenerator {
// True if batch mode is currently enabled.
bool batch_mode_;
- // True if FEC protection is on.
+ // True if FEC protection is on. The creator may have an open FEC group even
+ // if this variable is false.
bool should_fec_protect_;
// Flags to indicate the need for just-in-time construction of a frame.
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698