Re-styled App Info Dialog according to UI feedback 2

Re-styled App Info Dialog according to UI feedback 2

Re-styled the App Info Dialog again according to new UI feedback. This
involves moving the 'Remove' and 'Create Shortcuts' buttons into a new
AppInfoFooterPanel, which is displayed at the bottom of the app info
dialog.

Depends on review https://codereview.chromium.org/327743002/.

BUG=266739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278072

[sashab, 2014-06-17 00:48:00]

This CL adds the 'footer' panel to the App Info dialog and moves corresponding
information around according to the mocks.

This CL is based off https://codereview.chromium.org/327743002/.

[benwells, 2014-06-17 02:24:40]

only started looking, so may be more to come.

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:87: void
AppInfoDialog::Layout() {
I think this is needed to get the footer at the bottom. Is this something box
layout can do for free?

[benwells, 2014-06-17 03:00:40]

apart from this looking good.

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:8:
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
This in already included in the .h file

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:64:
left_aligned_buttons->SetLayoutManager(new views::BoxLayout(
I don't get why we need another box layout here. Isn't the one that you create
in the constructor enough?

[sashab, 2014-06-17 03:46:48]

Code is a lot smaller now :) Thanks.

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:87: void
AppInfoDialog::Layout() {
On 2014/06/17 02:24:40, benwells wrote:
> I think this is needed to get the footer at the bottom. Is this something box
> layout can do for free?

Found a way to do this with GridLayout :) Looks much better without the Layout()
override.

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:8:
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
On 2014/06/17 03:00:40, benwells wrote:
> This in already included in the .h file

Thanks; done.

https://codereview.chromium.org/335523002/diff/160001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:64:
left_aligned_buttons->SetLayoutManager(new views::BoxLayout(
On 2014/06/17 03:00:40, benwells wrote:
> I don't get why we need another box layout here. Isn't the one that you
create
> in the constructor enough?

Good find :) An artifact from old design. Fixed.

[benwells, 2014-06-17 03:55:07]

lgtm

[benwells, 2014-06-18 06:57:05]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-06-18 07:03:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/335523002/180001

[commit-bot: I haz the power, 2014-06-18 15:06:14]

Change committed as 278072