Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

Issue 335523002: Re-styled App Info Dialog according to UI feedback 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes, and removed border either side of the horizontal rules (doesn't match mocks anyway) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
index 886144134b8dfcf9aee89127c52be7ef72cb0325..da17ffc22324eba97d56a9e7fbbeebcd8fd6ef47 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
@@ -8,7 +8,6 @@
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h"
#include "chrome/common/extensions/extension_constants.h"
-#include "ui/views/controls/button/button.h"
#include "ui/views/controls/combobox/combobox_listener.h"
class LaunchOptionsComboboxModel;
@@ -18,21 +17,15 @@ namespace extensions {
class Extension;
}
-namespace ui {
-class Event;
-}
-
namespace views {
class Combobox;
class Label;
-class LabelButton;
}
// The summary panel of the app info dialog, which provides basic information
// and controls related to the app.
class AppInfoSummaryPanel : public AppInfoPanel,
- public views::ComboboxListener,
- public views::ButtonListener {
+ public views::ComboboxListener {
public:
AppInfoSummaryPanel(Profile* profile, const extensions::Extension* app);
@@ -42,18 +35,11 @@ class AppInfoSummaryPanel : public AppInfoPanel,
// Internal initialisation methods.
void CreateDescriptionControl();
void CreateLaunchOptionControl();
- void CreateShortcutsButton();
-
void LayoutDescriptionControl();
- void LayoutShortcutsButton();
// Overridden from views::ComboboxListener:
virtual void OnPerformAction(views::Combobox* combobox) OVERRIDE;
- // Overridden from views::ButtonListener.
- virtual void ButtonPressed(views::Button* sender,
- const ui::Event& event) OVERRIDE;
-
// Returns the launch type of the app (e.g. pinned tab, fullscreen, etc).
extensions::LaunchType GetLaunchType() const;
@@ -62,17 +48,10 @@ class AppInfoSummaryPanel : public AppInfoPanel,
void SetLaunchType(extensions::LaunchType) const;
bool CanSetLaunchType() const;
- // Create Shortcuts for the app. Must only be called if CanCreateShortcuts()
- // returns true.
- void CreateShortcuts();
- bool CanCreateShortcuts() const;
-
// UI elements on the dialog.
views::Label* description_heading_;
views::Label* description_label_;
- views::LabelButton* create_shortcuts_button_;
-
scoped_ptr<LaunchOptionsComboboxModel> launch_options_combobox_model_;
views::Combobox* launch_options_combobox_;

Powered by Google App Engine
This is Rietveld 408576698