Issue 335423002: Add @@iterator support for strings

Issue 335423002: Add @@iterator support for strings (Closed)

Created:
6 years, 6 months ago by wingo

Modified:
6 years, 6 months ago

Reviewers:
arv (Not doing code reviews), rossberg

CC:
v8-dev, arv (Not doing code reviews)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add @@iterator support for strings R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21994

Patch Set 2 : Fixed @@iterator property attributes #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -2 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/string-iterator.js	View	1	1 chunk	+106 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/iteration-semantics.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/harmony/string-iterator.js	View		1 chunk	+93 lines, -0 lines	1 comment	Download
M	tools/generate-runtime-tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

FYI https://codereview.chromium.org/335423002/diff/1/src/string-iterator.js File src/string-iterator.js (right): https://codereview.chromium.org/335423002/diff/1/src/string-iterator.js#newcode33 src/string-iterator.js:33: return this; wrong indentation https://codereview.chromium.org/335423002/diff/1/src/string-iterator.js#newcode104 src/string-iterator.js:104: DONT_ENUM | ...

6 years, 6 months ago (2014-06-17 15:33:19 UTC) #2

wingo

Fixed nits, thanks Erik. https://codereview.chromium.org/335423002/diff/1/src/string-iterator.js File src/string-iterator.js (right): https://codereview.chromium.org/335423002/diff/1/src/string-iterator.js#newcode33 src/string-iterator.js:33: return this; On 2014/06/17 15:33:19, ...

6 years, 6 months ago (2014-06-18 08:34:07 UTC) #3

rossberg

LGTM https://codereview.chromium.org/335423002/diff/20001/test/mjsunit/harmony/string-iterator.js File test/mjsunit/harmony/string-iterator.js (right): https://codereview.chromium.org/335423002/diff/20001/test/mjsunit/harmony/string-iterator.js#newcode90 test/mjsunit/harmony/string-iterator.js:90: object.next(); Nit: fits on one line

6 years, 6 months ago (2014-06-18 09:33:19 UTC) #4

wingo

6 years, 6 months ago (2014-06-25 07:43:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21994 (presubmit successful).

Expand Messages | Collapse Messages