Issue 335353002: Replace some hard coded schemes with the constants in /url/url_constants.h.

Issue 335353002: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed)

Created:
6 years, 6 months ago by Sungmann Cho

Modified:
6 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace some hard coded schemes with the constants in /url/url_constants.h. BUG=none TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277979

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Fix typos. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
M	url/gurl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	url/gurl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	url/url_canon_relative.cc	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	url/url_canon_stdurl.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	url/url_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	url/url_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	url/url_util.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Sungmann Cho

The CQ bit was checked by sungmann.cho@navercorp.com

6 years, 6 months ago (2014-06-17 18:34:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/335353002/1

6 years, 6 months ago (2014-06-17 18:36:45 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-17 23:44:55 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/162240)

6 years, 6 months ago (2014-06-17 23:44:56 UTC) #6

Sungmann Cho

The CQ bit was checked by sungmann.cho@navercorp.com

6 years, 6 months ago (2014-06-18 01:26:03 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/335353002/40001

6 years, 6 months ago (2014-06-18 01:28:01 UTC) #8

Message was sent while issue was closed.

Change committed as 277979

Expand Messages | Collapse Messages