url/url_canon_relative.cc - Issue 335353002: Replace some hard coded schemes with the constants in /url/url_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url_canon_relative.cc

Issue 335353002: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typos. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url/url_canon_relative.cc

diff --git a/url/url_canon_relative.cc b/url/url_canon_relative.cc

index 275a6fdadd064b5253a94b470cf37b5cba7070c7..9436245d3793d296b97964a72dbdf5710bd6f6e6 100644

--- a/url/url_canon_relative.cc

+++ b/url/url_canon_relative.cc

@@ -7,6 +7,7 @@

#include "base/logging.h"

#include "url/url_canon.h"

#include "url/url_canon_internal.h"

+#include "url/url_constants.h"

#include "url/url_file.h"

#include "url/url_parse_internal.h"

#include "url/url_util_internal.h"

@@ -145,7 +146,7 @@ bool DoIsRelativeURL(const char* base,

// If it's a filesystem URL, the only valid way to make it relative is not to

// supply a scheme. There's no equivalent to e.g. http:index.html.

- if (CompareSchemeComponent(url, scheme, "filesystem"))

+ if (CompareSchemeComponent(url, scheme, kFileSystemScheme))

return true;

// ExtractScheme guarantees that the colon immediately follows what it

« no previous file with comments | « url/gurl.cc ('k') | url/url_canon_stdurl.cc » ('j') | no next file with comments »