Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335343004: Revert 277794 "Modifies AudioInputCallback::OnData and use media..." (Closed)

Created:
6 years, 6 months ago by macourteau
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 277794 "Modifies AudioInputCallback::OnData and use media..." > Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector > > BUG=375155 > TEST=WebRTC and WebSpeech demos > > Review URL: https://codereview.chromium.org/314713002 R=henrika@chromium.org TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -399 lines) Patch
M trunk/src/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_sync_writer.h View 3 chunks +6 lines, -16 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_sync_writer.cc View 3 chunks +12 lines, -31 lines 0 comments Download
M trunk/src/content/browser/speech/speech_recognition_browsertest.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/content/browser/speech/speech_recognizer_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/speech/speech_recognizer_impl.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M trunk/src/content/browser/speech/speech_recognizer_impl_unittest.cc View 13 chunks +22 lines, -29 lines 0 comments Download
M trunk/src/media/audio/agc_audio_stream.h View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/media/audio/alsa/alsa_input.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/media/audio/alsa/alsa_input.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/media/audio/android/audio_android_unittest.cc View 5 chunks +15 lines, -21 lines 0 comments Download
M trunk/src/media/audio/android/audio_record_input.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/media/audio/android/audio_record_input.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M trunk/src/media/audio/android/opensles_input.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/media/audio/android/opensles_input.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M trunk/src/media/audio/audio_input_controller.h View 5 chunks +12 lines, -11 lines 0 comments Download
M trunk/src/media/audio/audio_input_controller.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M trunk/src/media/audio/audio_input_controller_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/media/audio/audio_input_device.cc View 5 chunks +13 lines, -21 lines 0 comments Download
M trunk/src/media/audio/audio_input_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/media/audio/audio_io.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/media/audio/cras/cras_input.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/media/audio/cras/cras_input.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/media/audio/cras/cras_input_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M trunk/src/media/audio/fake_audio_input_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/media/audio/fake_audio_input_stream.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M trunk/src/media/audio/mac/audio_input_mac.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/media/audio/mac/audio_input_mac.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M trunk/src/media/audio/mac/audio_low_latency_input_mac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/media/audio/mac/audio_low_latency_input_mac.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M trunk/src/media/audio/mac/audio_low_latency_input_mac_unittest.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M trunk/src/media/audio/pulse/pulse_input.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/media/audio/pulse/pulse_input.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M trunk/src/media/audio/pulse/pulse_output.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/media/audio/pulse/pulse_output.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/media/audio/virtual_audio_input_stream.cc View 1 chunk +8 lines, -1 line 0 comments Download
M trunk/src/media/audio/virtual_audio_input_stream_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_input_win.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_input_win.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_input_win_unittest.cc View 13 chunks +25 lines, -35 lines 0 comments Download
M trunk/src/media/audio/win/wavein_input_win.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/media/audio/win/wavein_input_win.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M trunk/src/media/base/audio_bus.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
macourteau
6 years, 6 months ago (2014-06-17 18:28:06 UTC) #1
henrika (OOO until Aug 14)
LGTM
6 years, 6 months ago (2014-06-17 18:30:10 UTC) #2
macourteau
6 years, 6 months ago (2014-06-17 18:36:45 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r277814 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698