Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 335273006: msvs: ensure that failing actions make the build fail with multiple actions (Closed)

Created:
6 years, 6 months ago by Stefan Haller
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

msvs: ensure that failing actions make the build fail with multiple actions The old way of joining multiple commands would take care of failing correctly when there are multiple actions associated with a single file. However, for multiple actions associated with different files (but within the same target), Visual Studio will still create just one .bat file for them all, so we must make sure that each command errors out correctly when it fails. Strictly speaking, the %errorlevel% check is unnecessary for the last command in a target (because the .bat file created by VS contains it already); but it doesn't hurt either, and makes the logic much simpler. Patch from Stefan Haller <stk.haller@googlemail.com>;. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
M pylib/gyp/generator/msvs.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/msvs/multiple_actions_error_handling/action_fail.py View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/msvs/multiple_actions_error_handling/action_succeed.py View 1 chunk +4 lines, -3 lines 0 comments Download
A test/msvs/multiple_actions_error_handling/actions.gyp View 1 chunk +40 lines, -0 lines 0 comments Download
A test/msvs/multiple_actions_error_handling/gyptest.py View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stefan Haller
6 years, 6 months ago (2014-06-20 15:36:49 UTC) #1
scottmg
Thanks! LGTM. I will land it.
6 years, 6 months ago (2014-06-20 16:26:22 UTC) #2
scottmg
6 years, 6 months ago (2014-06-20 17:43:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698