pylib/gyp/generator/msvs.py - Issue 335273006: msvs: ensure that failing actions make the build fail with multiple actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/msvs.py

Issue 335273006: msvs: ensure that failing actions make the build fail with multiple actions (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/msvs.py

diff --git a/pylib/gyp/generator/msvs.py b/pylib/gyp/generator/msvs.py

index b18bff18b245d81dc5e28b47642afd80197358a1..f548bb0eed76567b867d9137b029a4ec8cf6f054 100644

--- a/pylib/gyp/generator/msvs.py

+++ b/pylib/gyp/generator/msvs.py

@@ -3287,8 +3287,8 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):

# get too long. See also _AddActions: cygwin's setup_env mustn't be called

# for every invocation or the command that sets the PATH will grow too

# long.

- command = (

- '\r\nif %errorlevel% neq 0 exit /b %errorlevel%\r\n'.join(commands))

+ command = '\r\n'.join([c + '\r\nif %errorlevel% neq 0 exit /b %errorlevel%'

+ for c in commands])

_AddMSBuildAction(spec,

primary_input,

inputs,

« no previous file with comments | « no previous file | test/msvs/multiple_actions_error_handling/action_fail.py » ('j') | no next file with comments »