Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335273005: Rename "managed (mode|user)" to "supervised user" (part 3) (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, haitaol+watch_chromium.org, Pam (message me for reviews), chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 3) Followup to https://codereview.chromium.org/335833003/ and https://codereview.chromium.org/316863002/ This CL renames Managed->SupervisedUserSigninManagerWrapper. Still missing: - Some stuff outside of c/b/supervised_user/, mostly (but not only) c/b/chromeos/login/managed/ - JavaScript - Resource names - The global ENABLE_MANAGED_USERS define TBRing the c/b/sync part since it's just renames. TBR=atwilson@chromium.org BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279380

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -164 lines) Patch
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_sync.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/backup_rollback_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/backup_rollback_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/backup_rollback_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/sync/managed_user_signin_manager_wrapper.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/sync/managed_user_signin_manager_wrapper.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/startup_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/startup_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/startup_controller_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/sync/supervised_user_signin_manager_wrapper.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/sync/supervised_user_signin_manager_wrapper.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Marc Treib
atwilson: Please look at c/b/sync/ bauerb: Please look at c/b/supervised_user/ finnur: Please look at c/b/extensions/
6 years, 6 months ago (2014-06-20 16:21:59 UTC) #1
Finnur
c/b/e LGTM
6 years, 6 months ago (2014-06-20 16:33:15 UTC) #2
Bernhard Bauer
supervised_user/ LGTM.
6 years, 6 months ago (2014-06-20 16:39:18 UTC) #3
Pam (message me for reviews)
LGTM too, not that anyone asked. ;) But... https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h File chrome/browser/sync/backup_rollback_controller.h (right): https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h#newcode50 chrome/browser/sync/backup_rollback_controller.h:50: // ...
6 years, 6 months ago (2014-06-20 20:56:48 UTC) #4
Marc Treib
https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h File chrome/browser/sync/backup_rollback_controller.h (right): https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h#newcode50 chrome/browser/sync/backup_rollback_controller.h:50: // which would cause backup to trumpet normal sync ...
6 years, 6 months ago (2014-06-23 16:31:30 UTC) #5
Pam (message me for reviews)
https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h File chrome/browser/sync/backup_rollback_controller.h (right): https://codereview.chromium.org/335273005/diff/20001/chrome/browser/sync/backup_rollback_controller.h#newcode50 chrome/browser/sync/backup_rollback_controller.h:50: // which would cause backup to trumpet normal sync ...
6 years, 6 months ago (2014-06-23 17:00:25 UTC) #6
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-24 08:04:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/335273005/40001
6 years, 6 months ago (2014-06-24 08:06:17 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 11:54:26 UTC) #9
Message was sent while issue was closed. 
Change committed as 279380

Powered by Google App Engine
This is Rietveld 408576698