Rename "managed (mode|user)" to "supervised user" (part 3)

chrome/browser/sync/backup_rollback_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_BACKUP_ROLLBACK_CONTROLLER_H_
 #define CHROME_BROWSER_SYNC_BACKUP_ROLLBACK_CONTROLLER_H_
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 
-class ManagedUserSigninManagerWrapper;
+class SupervisedUserSigninManagerWrapper;
 
 namespace sync_driver {
 class SyncPrefs;
 }
 
 namespace browser_sync {
 
 // BackupRollbackController takes two closures for starting backup/rollback
 // process. It calls the closures according to user's signin status or
 // received rollback command. Backup is not run when user signed in, even when
 // sync is not running.
 class BackupRollbackController {
  public:
   BackupRollbackController(sync_driver::SyncPrefs* sync_prefs,
-                           const ManagedUserSigninManagerWrapper* signin,
+                           const SupervisedUserSigninManagerWrapper* signin,
                            base::Closure start_backup,
                            base::Closure start_rollback);
   ~BackupRollbackController();
 
   // Check to see whether to start backup/rollback. |delay| specifies the time
   // to wait before checking.
   void Start(base::TimeDelta delay);
 
   // Update rollback preference to indicate rollback is needed.
   void OnRollbackReceived();
 
   // Update rollback preference to indicate rollback is finished.
   void OnRollbackDone();
 
  private:
   // Check signin status and rollback preference and start backup/rollback
   // accordingly.
   void TryStart();
 
   sync_driver::SyncPrefs* sync_prefs_;
 
-  // Use ManagedUserSigninManagerWrapper instead of SigninManagerBase because
-  // SigninManagerBase could return non-empty user name for managed user, which
-  // would cause backup to trumpet normal sync for managed user.
-  const ManagedUserSigninManagerWrapper* signin_;
+  // Use SupervisedUserSigninManagerWrapper instead of SigninManagerBase because
+  // SigninManagerBase could return non-empty user name for supervised user,
+  // which would cause backup to trumpet normal sync for supervised user.

[Pam (message me for reviews), 2014/06/20 20:56:48]

What does "backup to trumpet normal sync" mean?

[Marc Treib, 2014/06/23 16:31:30]

I'm guessing "trumpet" should read "trump", which would make a bit more sense.
From looking at the code, though, the issue seems to be that
SigninManager::GetAuthenticatedUsername *does* return an empty string for
supervised users.

[Pam (message me for reviews), 2014/06/23 17:00:24]

I'm not even sure what that means. What is "backup" here? Can we clarify the
comment (in another CL)?

On 2014/06/23 16:31:30, treib wrote:

+  const SupervisedUserSigninManagerWrapper* signin_;
 
   base::Closure start_backup_;
   base::Closure start_rollback_;
   base::WeakPtrFactory<BackupRollbackController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackupRollbackController);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_BACKUP_ROLLBACK_CONTROLLER_H_