Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335243002: Convert results.Add to results.AddValue for speedindex metrics. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert results.Add to results.AddValue for speedindex metrics. BUG=383153 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/metrics/speedindex.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-16 21:30:55 UTC) #1
tonyg
lgtm
6 years, 6 months ago (2014-06-17 15:08:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/335243002/1
6 years, 6 months ago (2014-06-17 15:10:30 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 19:16:48 UTC) #4
Message was sent while issue was closed. 
Change committed as 277833

Powered by Google App Engine
This is Rietveld 408576698