Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/perf/metrics/speedindex.py

Issue 335243002: Convert results.Add to results.AddValue for speedindex metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/speedindex.py
diff --git a/tools/perf/metrics/speedindex.py b/tools/perf/metrics/speedindex.py
index 1b270397a5e5a9cf8c2f158007b72487cdaf2beb..296c81934c48749b21ef69e2907998eca87bc336 100644
--- a/tools/perf/metrics/speedindex.py
+++ b/tools/perf/metrics/speedindex.py
@@ -6,6 +6,7 @@ import collections
from metrics import Metric
from telemetry.core import bitmap
+from telemetry.value import scalar
class SpeedIndexMetric(Metric):
@@ -51,7 +52,8 @@ class SpeedIndexMetric(Metric):
index = self._impl.CalculateSpeedIndex(tab)
# Release the tab so that it can be disconnected.
self._impl = None
- results.Add('speed_index', 'ms', index, chart_name=chart_name)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%s.speed_index' % chart_name, 'ms', index))
def IsFinished(self, tab):
"""Decide whether the timeline recording should be stopped.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698