Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8494)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

Issue 335233003: Convert ui::ScaleFactor -> float in favicon/history code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
index dfd55987c514056e6ad32d4aaaf2278d94250ec2..9e61f863f2868eec9aa5d52425513ca709d352ad 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
@@ -10,7 +10,6 @@
#include "components/favicon_base/favicon_callback.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_controller_factory.h"
-#include "ui/base/layout.h"
class Profile;
@@ -36,7 +35,7 @@ class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {
void GetFaviconForURL(
Profile* profile,
const GURL& page_url,
- const std::vector<ui::ScaleFactor>& scale_factors,
+ const std::vector<float>& favicon_scales,
const favicon_base::FaviconResultsCallback& callback) const;
static ChromeWebUIControllerFactory* GetInstance();
@@ -53,8 +52,8 @@ class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {
// The returned favicon data must be
// |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should
// be updated if this changes.
- base::RefCountedMemory* GetFaviconResourceBytes(
- const GURL& page_url, ui::ScaleFactor scale_factor) const;
+ base::RefCountedMemory* GetFaviconResourceBytes(const GURL& page_url,
+ float favicon_scale) const;
DISALLOW_COPY_AND_ASSIGN(ChromeWebUIControllerFactory);
};

Powered by Google App Engine
This is Rietveld 408576698