Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3486)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 335233003: Convert ui::ScaleFactor -> float in favicon/history code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index d9bd629f3da004599d961095cb0c743d2056b006..90b72748f2b17bd3bc9db142de4223fb0a70d3e1 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -74,6 +74,7 @@
#include "extensions/common/extension.h"
#include "extensions/common/feature_switch.h"
#include "extensions/common/manifest.h"
+#include "ui/base/layout.h"
#include "ui/gfx/favicon_size.h"
#include "ui/web_dialogs/web_dialog_ui.h"
#include "url/gurl.h"
@@ -570,7 +571,7 @@ WebUIController* ChromeWebUIControllerFactory::CreateWebUIControllerForURL(
void ChromeWebUIControllerFactory::GetFaviconForURL(
Profile* profile,
const GURL& page_url,
- const std::vector<ui::ScaleFactor>& scale_factors,
+ const std::vector<float>& favicon_scales,
const favicon_base::FaviconResultsCallback& callback) const {
// Before determining whether page_url is an extension url, we must handle
// overrides. This changes urls in |kChromeUIScheme| to extension urls, and
@@ -594,9 +595,9 @@ void ChromeWebUIControllerFactory::GetFaviconForURL(
std::vector<favicon_base::FaviconRawBitmapResult>* favicon_bitmap_results =
new std::vector<favicon_base::FaviconRawBitmapResult>();
- for (size_t i = 0; i < scale_factors.size(); ++i) {
- scoped_refptr<base::RefCountedMemory> bitmap(GetFaviconResourceBytes(
- url, scale_factors[i]));
+ for (size_t i = 0; i < favicon_scales.size(); ++i) {
+ scoped_refptr<base::RefCountedMemory> bitmap(
+ GetFaviconResourceBytes(url, favicon_scales[i]));
if (bitmap.get() && bitmap->size()) {
favicon_base::FaviconRawBitmapResult bitmap_result;
bitmap_result.bitmap_data = bitmap;
@@ -606,7 +607,7 @@ void ChromeWebUIControllerFactory::GetFaviconForURL(
// Assume that |bitmap| is |gfx::kFaviconSize| x |gfx::kFaviconSize|
// DIP.
- float scale = ui::GetScaleForScaleFactor(scale_factors[i]);
+ float scale = favicon_scales[i];
int edge_pixel_size =
static_cast<int>(gfx::kFaviconSize * scale + 0.5f);
bitmap_result.pixel_size = gfx::Size(edge_pixel_size, edge_pixel_size);
@@ -628,7 +629,9 @@ ChromeWebUIControllerFactory::~ChromeWebUIControllerFactory() {
}
base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
- const GURL& page_url, ui::ScaleFactor scale_factor) const {
+ const GURL& page_url,
+ float scale) const {
+ ui::ScaleFactor scale_factor = ui::GetSupportedScaleFactor(scale);
#if !defined(OS_ANDROID) // Bookmarks are part of NTP on Android.
// The bookmark manager is a chrome extension, so we have to check for it
// before we check for extension scheme.

Powered by Google App Engine
This is Rietveld 408576698