Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: pkg/analysis_server/lib/src/protocol.dart

Issue 335123008: Implement analysis.updateOptions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/protocol.dart
diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart
index 1da0ba49fee2b5ac5dd93c08794b8662f2900465..fae8c53990b9db38388d0a1996028ed1ac1839d3 100644
--- a/pkg/analysis_server/lib/src/protocol.dart
+++ b/pkg/analysis_server/lib/src/protocol.dart
@@ -537,6 +537,14 @@ class Response {
: this(request.id, new RequestError(-11, "Unanalyzed files cannot be a priority: '$fileNames'"));
/**
+ * Initialize a newly created instance to represent an error condition caused
+ * by a `analysis.updateOptions` [request] that includes an unknown analysis
+ * option.
+ */
+ Response.unknownOptionName(Request request, String optionName)
+ : this(request.id, new RequestError(-12, 'Unknown analysis option: "$optionName"'));
Paul Berry 2014/06/17 20:40:54 I have a vague memory that we decided to simply ig
Brian Wilkerson 2014/06/17 21:30:12 We thought it might help with version skew issues,
Paul Berry 2014/06/17 22:24:56 Now that I think about it again, I don't really ha
+
+ /**
* Initialize a newly created instance based upon the given JSON data
*/
factory Response.fromJson(Map<String, Object> json) {

Powered by Google App Engine
This is Rietveld 408576698