Implement analysis.updateOptions

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:collection';
 import 'dart:convert' show JsonDecoder;
 
 /**
@@ skipping 519 matching lines @@
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a `analysis.setPriorityFiles` [request] that includes one or more files
    * that are not being analyzed.
    */
   Response.unanalyzedPriorityFiles(Request request, String fileNames)
     : this(request.id, new RequestError(-11, "Unanalyzed files cannot be a priority: '$fileNames'"));
 
   /**
+   * Initialize a newly created instance to represent an error condition caused
+   * by a `analysis.updateOptions` [request] that includes an unknown analysis
+   * option.
+   */
+  Response.unknownOptionName(Request request, String optionName)
+    : this(request.id, new RequestError(-12, 'Unknown analysis option: "$optionName"'));

[Paul Berry, 2014/06/17 20:40:54]

I have a vague memory that we decided to simply ignore unrecognized options. 
Can't remember why, though.

[Brian Wilkerson, 2014/06/17 21:30:12]

We thought it might help with version skew issues, but I think it might be
better to let the client know if they're using a version of the server that
doesn't support an option they're depending on. Let me know if you disagree.

[Paul Berry, 2014/06/17 22:24:56]

Now that I think about it again, I don't really have a strong opinion.

+
+  /**
    * Initialize a newly created instance based upon the given JSON data
    */
   factory Response.fromJson(Map<String, Object> json) {
     try {
       Object id = json[Response.ID];
       if (id is! String) {
         return null;
       }
       Object error = json[Response.ERROR];
       Object result = json[Response.RESULT];
@@ skipping 319 matching lines @@
   /**
    * The response to be returned as a result of the failure.
    */
   final Response response;
 
   /**
    * Initialize a newly created exception to return the given reponse.
    */
   RequestFailure(this.response);
 }