Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 335113008: Wire up component cloud policy to device local accounts. (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Wire up component cloud policy to device local accounts. Note: this is a reland of https://codereview.chromium.org/341043005 which was reverted due to memory leaks in tests. Those leaks were fixed in https://codereview.chromium.org/348713004. This enables policy-for-extensions running in Public Sessions, and for extensions running as Kiosk Apps too. TBR=bartfab@chromium.org BUG=224596 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278734

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -55 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 5 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.h View 5 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 6 chunks +69 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.h View 6 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 14 chunks +47 lines, -29 lines 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 8 chunks +21 lines, -6 lines 0 comments Download
M chromeos/chromeos_paths.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/chromeos_paths.cc View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-20 11:11:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/335113008/1
6 years, 6 months ago (2014-06-20 11:13:23 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-20 14:50:09 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 15:23:15 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19868)
6 years, 6 months ago (2014-06-20 15:23:16 UTC) #5
Joao da Silva
6 years, 6 months ago (2014-06-20 17:12:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r278734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698