Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 348713004: Use a TestBrowserThreadBundle in the DeviceSettingsTestBase. (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
pastarmovj, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a TestBrowserThreadBundle in the DeviceSettingsTestBase. Lots of policy tests inherit from that class to reuse common setup code. The recent work on cloud policy for extensions wired a new class to some of the existing ones that posts a cleanup task to the IO thread, and DeviceSettingsTestBase wasn't mocking that thread; so these tests started leaking at shutdown. The TestBrowserThreadBundle sets up the UI and FILE threads that the tests were expecting as well as the other common threads, which makes these tests more robust. TBR=pastarmovj@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278648

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Joao da Silva
Here's a fix for the leak. I've verified it locally and looks good; I'm also ...
6 years, 6 months ago (2014-06-20 01:02:49 UTC) #1
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-20 01:06:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/348713004/1
6 years, 6 months ago (2014-06-20 01:07:13 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 08:30:12 UTC) #4
Message was sent while issue was closed.
Change committed as 278648

Powered by Google App Engine
This is Rietveld 408576698