Issue 335053003: Clarify comments about the role of the lex/parse table cache action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335053003: Clarify comments about the role of the lex/parse table cache action (Closed)

Created:
6 years, 5 months ago by Jens Widell

Modified:
6 years, 5 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clarify comments about the role of the lex/parse table cache action The comment claimed the explicit cache update step wasn't required, and explained why we still did it. This was correct for a clean build, but for an incremental build, when stale cache files might exist, it was incorrect; the explicit cache update step is in fact required to refresh a stale cache. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176917

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	Source/bindings/scripts/BUILD.gn	View		1 chunk	+6 lines, -5 lines	0 comments	Download
	M	Source/bindings/scripts/scripts.gyp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/335053003/1

6 years, 5 months ago (2014-06-25 09:23:54 UTC) #4

Message was sent while issue was closed.

Change committed as 176917

Expand Messages | Collapse Messages