Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: Source/bindings/scripts/scripts.gyp

Issue 335053003: Clarify comments about the role of the lex/parse table cache action (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/scripts.gyp
diff --git a/Source/bindings/scripts/scripts.gyp b/Source/bindings/scripts/scripts.gyp
index d8d8687171305908ed0762ec6931d35c70778e7b..bb5319022096115915b24fde8087490acf6cecd4 100644
--- a/Source/bindings/scripts/scripts.gyp
+++ b/Source/bindings/scripts/scripts.gyp
@@ -16,11 +16,11 @@
'targets': [
################################################################################
{
- # A separate pre-caching step is *not required* to use lex/parse table
- # caching in PLY, as the caches are concurrency-safe.
- # However, pre-caching ensures that all compiler processes use the cached
- # files (hence maximizing speed), instead of early processes building the
- # tables themselves (as they've not yet been written when they start).
+ # This separate pre-caching step is required to use lex/parse table caching
+ # in PLY, since PLY itself does not check if the cache is valid, and may end
+ # up using a stale cache if this step hasn't been run to update it.
+ #
+ # This action's dependencies *is* the cache validation.
#
# GN version: //third_party/WebKit/Source/bindings/scripts:cached_lex_yacc_tables
'target_name': 'cached_lex_yacc_tables',
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698