Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 334993002: hide virtuals on device for width/height/isopaque (Closed)

Created:
6 years, 6 months ago by reed2
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

hide virtuals on device for width/height/isopaque TBR= NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/f252f64f17efddf7235682a96d155d7c86c898e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -59 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -12 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +21 lines, -11 lines 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +2 lines, -10 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed2
6 years, 6 months ago (2014-06-13 21:18:30 UTC) #1
reed2
The CQ bit was checked by reed@chromium.org
6 years, 6 months ago (2014-06-14 02:15:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/334993002/1
6 years, 6 months ago (2014-06-14 02:15:56 UTC) #3
reed2
The CQ bit was unchecked by reed@chromium.org
6 years, 6 months ago (2014-06-14 11:24:36 UTC) #4
reed2
The CQ bit was checked by reed@chromium.org
6 years, 6 months ago (2014-06-14 11:24:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/334993002/1
6 years, 6 months ago (2014-06-14 11:24:50 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 11:25:01 UTC) #7
Message was sent while issue was closed.
Change committed as f252f64f17efddf7235682a96d155d7c86c898e3

Powered by Google App Engine
This is Rietveld 408576698