Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/utils/SkPictureUtils.cpp

Issue 334993002: hide virtuals on device for width/height/isopaque (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/utils/SkGatherPixelRefsAndRects.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmapDevice.h" 8 #include "SkBitmapDevice.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkData.h" 10 #include "SkData.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 class GatherPixelRefDevice : public SkBaseDevice { 51 class GatherPixelRefDevice : public SkBaseDevice {
52 public: 52 public:
53 SK_DECLARE_INST_COUNT(GatherPixelRefDevice) 53 SK_DECLARE_INST_COUNT(GatherPixelRefDevice)
54 54
55 GatherPixelRefDevice(int width, int height, PixelRefSet* prset) { 55 GatherPixelRefDevice(int width, int height, PixelRefSet* prset) {
56 fSize.set(width, height); 56 fSize.set(width, height);
57 fEmptyBitmap.setInfo(SkImageInfo::MakeUnknown(width, height)); 57 fEmptyBitmap.setInfo(SkImageInfo::MakeUnknown(width, height));
58 fPRSet = prset; 58 fPRSet = prset;
59 } 59 }
60 60
61 virtual int width() const SK_OVERRIDE { return fSize.width(); } 61 virtual SkImageInfo imageInfo() const SK_OVERRIDE {
62 virtual int height() const SK_OVERRIDE { return fSize.height(); } 62 return SkImageInfo::MakeUnknown(fSize.width(), fSize.height());
63 virtual bool isOpaque() const SK_OVERRIDE { return false; } 63 }
64 virtual GrRenderTarget* accessRenderTarget() SK_OVERRIDE { return NULL; } 64 virtual GrRenderTarget* accessRenderTarget() SK_OVERRIDE { return NULL; }
65 virtual bool filterTextFlags(const SkPaint& paint, TextFlags*) SK_OVERRIDE { 65 virtual bool filterTextFlags(const SkPaint& paint, TextFlags*) SK_OVERRIDE {
66 return false; 66 return false;
67 } 67 }
68 // TODO: allow this call to return failure, or move to SkBitmapDevice only. 68 // TODO: allow this call to return failure, or move to SkBitmapDevice only.
69 virtual const SkBitmap& onAccessBitmap() SK_OVERRIDE { 69 virtual const SkBitmap& onAccessBitmap() SK_OVERRIDE {
70 return fEmptyBitmap; 70 return fEmptyBitmap;
71 } 71 }
72 virtual void lockPixels() SK_OVERRIDE { nothing_to_do(); } 72 virtual void lockPixels() SK_OVERRIDE { nothing_to_do(); }
73 virtual void unlockPixels() SK_OVERRIDE { nothing_to_do(); } 73 virtual void unlockPixels() SK_OVERRIDE { nothing_to_do(); }
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 canvas.clipRect(area, SkRegion::kIntersect_Op, false); 211 canvas.clipRect(area, SkRegion::kIntersect_Op, false);
212 canvas.drawPicture(pict); 212 canvas.drawPicture(pict);
213 213
214 SkData* data = NULL; 214 SkData* data = NULL;
215 int count = array.count(); 215 int count = array.count();
216 if (count > 0) { 216 if (count > 0) {
217 data = SkData::NewFromMalloc(array.detach(), count * sizeof(SkPixelRef*) ); 217 data = SkData::NewFromMalloc(array.detach(), count * sizeof(SkPixelRef*) );
218 } 218 }
219 return data; 219 return data;
220 } 220 }
OLDNEW
« no previous file with comments | « src/utils/SkGatherPixelRefsAndRects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698