Issue 33483002: Have Frame::animation() return a reference

Issue 33483002: Have Frame::animation() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), zoltan1, eae+blinkwatch, Timothy Loh, leviw+renderwatch, blink-layers+watch_chromium.org, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Frame::animation() return a reference Have Frame::animation() return a reference instead of a pointer as it can never return null. This makes the calling code look safer and gets rid a several unnecessary null-checks. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160166

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -32 lines)			Patch
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/Frame.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/animation/AnimationController.h	View	1 chunk	+7 lines, -1 line	1 comment	Download
M	Source/core/rendering/CompositedLayerMapping.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderLayerCompositor.cpp	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/33483002/diff/1/Source/core/frame/animation/AnimationController.h File Source/core/frame/animation/AnimationController.h (right): https://codereview.chromium.org/33483002/diff/1/Source/core/frame/animation/AnimationController.h#newcode87 Source/core/frame/animation/AnimationController.h:87: explicit AnimationUpdateBlock(AnimationController& animationController) I added this constructor taking a ...

7 years, 2 months ago (2013-10-21 19:15:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33483002/1

7 years, 2 months ago (2013-10-21 19:55:18 UTC) #3

Message was sent while issue was closed.

Change committed as 160166

Expand Messages | Collapse Messages