Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 334803002: Cleanup [RuntimeEnabled] use in CanvasRenderingContext2D (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Rik, Inactive, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, eseidel, jcgregorio1, Jens Widell
Project:
blink
Visibility:
Public.

Description

Cleanup [RuntimeEnabled] use in CanvasRenderingContext2D This removes some cruft added in: Add versions of stroke, fill, and clip that take a Path parameter. https://codereview.chromium.org/137353004/ ...which was done b/c [RuntimeEnabled] didn't work properly on overloaded methods. This has been fixed (thanks Jens!) and thus the cruft can be removed. R=haraken BUG=339000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +7 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
decruft, decruft
6 years, 6 months ago (2014-06-13 02:31:41 UTC) #1
haraken
Great, thanks! LGTM.
6 years, 6 months ago (2014-06-13 02:45:23 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 03:05:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/334803002/1
6 years, 6 months ago (2014-06-13 03:06:17 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 04:40:15 UTC) #5
Message was sent while issue was closed.
Change committed as 176086

Powered by Google App Engine
This is Rietveld 408576698