Chromium Code Reviews
Help | Chromium Project | Sign in
(17)

Issue 3348006: o3djs: Recommit effect.js for skinning shader.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Patrick Horn
Modified:
2 years, 11 months ago
Reviewers:
petersont
CC:
o3d-review_googlegroups.com, Daniel
Visibility:
Public.

Description

o3djs: Recommit effect.js for skinning shader.

Also fixes skinning error in FF4 when getParameter(MAX_VERTEX_UNIFORM_VECTORS)
gives GL_INVALID_ENUM.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59469

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -9 lines) Lint Patch
M o3d-webgl/skin.js View 1 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M o3djs/effect.js View 1 11 chunks +83 lines, -9 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Patrick Horn
effect.js got reverted recently, which was a good thing because skinning broke on recent FF ...
3 years, 7 months ago #1
Patrick Horn
ping The effect.js is a automatic svn merge of what was committed with my original ...
3 years, 7 months ago #2
petersont
3 years, 7 months ago #3
lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6