Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334793002: hide Config in SkImageDecoder -- use SkColorType instead (Closed)

Created:
6 years, 6 months ago by reed2
Modified:
6 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

hide Config in SkImageDecoder -- use SkColorType instead patch from issue 334613003 TBR=scroggo Committed: https://skia.googlesource.com/skia/+/bfefc7c95fc0e8ebd5000c68f6d16e1a3ea0e71e

Patch Set 1 #

Patch Set 2 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -160 lines) Patch
M bench/DecodeBench.cpp View 3 chunks +9 lines, -16 lines 0 comments Download
M experimental/PdfViewer/chop_transparency_main.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/cmykjpeg.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M gm/copyTo4444.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/filterbitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/filterindiabox.cpp View 4 chunks +3 lines, -9 lines 0 comments Download
M gm/gm_expectations.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageDecoder.h View 8 chunks +47 lines, -36 lines 0 comments Download
M samplecode/SampleFilter2.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M samplecode/SampleSubpixelTranslate.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleUnpremul.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/image/SkImage_Codec.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 7 chunks +18 lines, -21 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 9 chunks +11 lines, -15 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skdiff_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skimage_main.cpp View 7 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
The CQ bit was checked by reed@chromium.org
6 years, 6 months ago (2014-06-13 00:20:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/334793002/20001
6 years, 6 months ago (2014-06-13 00:20:56 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:40:05 UTC) #3
Message was sent while issue was closed. 
Change committed as bfefc7c95fc0e8ebd5000c68f6d16e1a3ea0e71e

Powered by Google App Engine
This is Rietveld 408576698