tools/skdiff_utils.cpp - Issue 334793002: hide Config in SkImageDecoder -- use SkColorType instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_utils.cpp

Issue 334793002: hide Config in SkImageDecoder -- use SkColorType instead (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_utils.cpp

diff --git a/tools/skdiff_utils.cpp b/tools/skdiff_utils.cpp

index 5c9aae275aab23dd7755f6490e774522ac0bb3c6..9157ac6b918c2568cce427ad968002a5d2b05281 100644

--- a/tools/skdiff_utils.cpp

+++ b/tools/skdiff_utils.cpp

@@ -63,7 +63,7 @@ bool get_bitmap(SkData* fileBits, DiffResource& resource, SkImageDecoder::Mode m

SkAutoTDelete<SkImageDecoder> ad(codec);

stream.rewind();

- if (!codec->decode(&stream, &resource.fBitmap, SkBitmap::kARGB_8888_Config, mode)) {

+ if (!codec->decode(&stream, &resource.fBitmap, kN32_SkColorType, mode)) {

SkDebugf("ERROR: codec failed for basePath <%s>\n", resource.fFullPath.c_str());

resource.fStatus = DiffResource::kCouldNotDecode_Status;

return false;

« no previous file with comments | « tools/render_pictures_main.cpp ('k') | tools/skimage_main.cpp » ('j') | no next file with comments »