Issue 334773002: Avoid calling AlertDialog.Builder.setOnDismissListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334773002: Avoid calling AlertDialog.Builder.setOnDismissListener. (Closed)

Created:
6 years, 6 months ago by aruslan

Modified:
6 years, 6 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Avoid calling AlertDialog.Builder.setOnDismissListener. That call is only available since API level 17. BUG=380210 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276793

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

Joao da Silva

lgtm, thanks! I spent some time looking at the other APIs called from SigninManager. AFAICT, ...

6 years, 6 months ago (2014-06-12 19:55:38 UTC) #2

aruslan

On 2014/06/12 19:55:38, Joao da Silva wrote: > lgtm, thanks! > > I spent some ...

6 years, 6 months ago (2014-06-12 20:25:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/334773002/1

6 years, 6 months ago (2014-06-12 20:28:48 UTC) #5

Message was sent while issue was closed.

Change committed as 276793