chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java - Issue 334773002: Avoid calling AlertDialog.Builder.setOnDismissListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

Issue 334773002: Avoid calling AlertDialog.Builder.setOnDismissListener. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

index fc1ba0226cf2f4c14958620293754d7b23b814fc..72124d7e3e4b1fc0b372614050f3c114fd72249b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

@@ -245,7 +245,8 @@ public class SigninManager {

mPolicyConfirmationDialog = null;

}

});

- builder.setOnDismissListener(

+ mPolicyConfirmationDialog = builder.create();

+ mPolicyConfirmationDialog.setOnDismissListener(

new DialogInterface.OnDismissListener() {

@Override

public void onDismiss(DialogInterface dialog) {

@@ -256,7 +257,6 @@ public class SigninManager {

}

});

- mPolicyConfirmationDialog = builder.create();

mPolicyConfirmationDialog.show();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »