Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334753003: Reland: Fix slop region boundary handling. (Closed)

Created:
6 years, 6 months ago by tdresser
Modified:
6 years, 6 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland: Fix slop region boundary handling. Committed https://src.chromium.org/viewvc/chrome?view=rev&revision=276728. Broke gn build. Reverted: https://codereview.chromium.org/330613003 Ensure the screenPosition of touches is never truncated to an integer. Check if the unified gesture detector is enabled before disabling the inclusive slop region. BUG=381174 TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276852

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Reupload missing file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -26 lines) Patch
M content/browser/renderer_host/input/input_router_config_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/events.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 2 chunks +2 lines, -22 lines 0 comments Download
A ui/events/gestures/unified_gesture_detector_enabled.h View 2 1 chunk +17 lines, -0 lines 0 comments Download
ui/events/gestures/unified_gesture_detector_enabled.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tdresser
Only change is in BUILD.gn.
6 years, 6 months ago (2014-06-12 18:12:13 UTC) #1
jdduke (slow)
Still lgtm, feel free to TBR me on trivial fixes like this.
6 years, 6 months ago (2014-06-12 18:35:05 UTC) #2
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 6 months ago (2014-06-12 18:41:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/334753003/40001
6 years, 6 months ago (2014-06-12 18:44:00 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 23:47:21 UTC) #5
Message was sent while issue was closed. 
Change committed as 276852

Powered by Google App Engine
This is Rietveld 408576698