Issue 330613003: Revert 276728 "Fix slop region boundary handling."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330613003: Revert 276728 "Fix slop region boundary handling." (Closed)

Created:
6 years, 6 months ago by tdresser

Modified:
6 years, 6 months ago

Reviewers:
tdresser

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 276728 "Fix slop region boundary handling." > Fix slop region boundary handling. > > Ensure the screenPosition of touches is never truncated to an integer. > > Check if the unified gesture detector is enabled before disabling > the inclusive slop region. > > BUG=381174 > TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded > > Review URL: https://codereview.chromium.org/328733003 TBR=tdresser@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276732

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -94 lines)			Patch
M	trunk/src/content/browser/renderer_host/input/input_router_config_helper.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/ui_events_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/events/event.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/ui/events/events.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/events/gestures/gesture_recognizer_impl.cc	View	2 chunks	+22 lines, -2 lines	0 comments	Download
D	trunk/src/ui/events/gestures/unified_gesture_detector_enabled.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	trunk/src/ui/events/gestures/unified_gesture_detector_enabled.cc	View	1 chunk	+0 lines, -37 lines	0 comments	Download

Total messages: 2 (0 generated)

tdresser

6 years, 6 months ago (2014-06-12 17:32:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r276732 (tree was closed).