Issue 334743011: Version 3.26.31.5 (revert r21509, r21858, r21525)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334743011: Version 3.26.31.5 (revert r21509, r21858, r21525) (Closed)

Created:
6 years, 6 months ago by danno

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer, Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.26

Visibility:
Public.

More Reviews

Description

Version 3.26.31.5 (revert r21509, r21858, r21525) Avoid HeapObject check in HStoreNamedField. Add unit test for regression in GVN caused by field type MIPS: Avoid HeapObject check in HStoreNamedField. BUG=v8:3347 LOG=N TBR=bmeurer@chromium.org,ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21861

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -104 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	3 chunks	+18 lines, -7 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	3 chunks	+15 lines, -9 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+24 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	3 chunks	+18 lines, -7 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+23 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	test/mjsunit/regress/regress-gvn-ftt.js	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

danno

6 years, 6 months ago (2014-06-16 20:45:45 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21861 (tree was closed).

Expand Messages | Collapse Messages