Index: src/arm64/lithium-codegen-arm64.cc |
diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc |
index 048004bc7191e12b09341f2f74a1e877d2922ffe..17243c8dbe1a18fc689bd220affa05ff9982e3f5 100644 |
--- a/src/arm64/lithium-codegen-arm64.cc |
+++ b/src/arm64/lithium-codegen-arm64.cc |
@@ -5257,11 +5257,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { |
Register value = ToRegister(instr->value()); |
__ Store(value, MemOperand(object, offset), representation); |
return; |
- } |
- |
- __ AssertNotSmi(object); |
- |
- if (representation.IsDouble()) { |
+ } else if (representation.IsDouble()) { |
ASSERT(access.IsInobject()); |
ASSERT(!instr->hydrogen()->has_transition()); |
ASSERT(!instr->hydrogen()->NeedsWriteBarrier()); |
@@ -5272,9 +5268,19 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { |
Register value = ToRegister(instr->value()); |
- ASSERT(!representation.IsSmi() || |
- !instr->value()->IsConstantOperand() || |
- IsInteger32Constant(LConstantOperand::cast(instr->value()))); |
+ SmiCheck check_needed = instr->hydrogen()->value()->IsHeapObject() |
+ ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; |
+ |
+ ASSERT(!(representation.IsSmi() && |
+ instr->value()->IsConstantOperand() && |
+ !IsInteger32Constant(LConstantOperand::cast(instr->value())))); |
+ if (representation.IsHeapObject() && |
+ !instr->hydrogen()->value()->type().IsHeapObject()) { |
+ DeoptimizeIfSmi(value, instr->environment()); |
+ |
+ // We know now that value is not a smi, so we can omit the check below. |
+ check_needed = OMIT_SMI_CHECK; |
+ } |
if (instr->hydrogen()->has_transition()) { |
Handle<Map> transition = instr->hydrogen()->transition_map(); |
@@ -5334,7 +5340,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { |
GetLinkRegisterState(), |
kSaveFPRegs, |
EMIT_REMEMBERED_SET, |
- instr->hydrogen()->SmiCheckForWriteBarrier()); |
+ check_needed); |
} |
} |