Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 334713006: Use stricter typing for NodeLists throughout the code base (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
haraken, esprehn, adamk
CC:
aandrey+blink_chromium.org, aboxhall, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, gyuyoung.kim_webkit.org, Nate Chapin, kouhei+svg_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, webcomponents-bugzilla_chromium.org, yurys+blink_chromium.org, Nils Barth (inactive)
Project:
blink
Visibility:
Public.

Description

Use stricter typing for NodeLists throughout the code base Use stricter typing for NodeLists throughout the code base. This makes it clearer what exact type we are actually dealing with. This also allows the compiler to de-virtualize some function calls with C++11. R=adamk@chromium.org, esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176427

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix typo #

Total comments: 10

Patch Set 4 : Take haraken's feedback into consideration #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -107 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/accessibility/AXTable.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 3 chunks +8 lines, -5 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 3 5 chunks +6 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 5 2 chunks +0 lines, -16 lines 0 comments Download
M Source/core/dom/MutationRecord.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/MutationRecord.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/NamedNodesCollection.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ParentNode.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RangeTest.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/SelectorQuery.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/Event.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/NodeEventContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/TreeScopeEventContext.h View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TreeScopeEventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/LabelableElement.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/LabelableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 3 4 5 4 chunks +2 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebNode.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Inactive
https://codereview.chromium.org/334713006/diff/40001/Source/core/dom/Document.h File Source/core/dom/Document.h (left): https://codereview.chromium.org/334713006/diff/40001/Source/core/dom/Document.h#oldcode348 Source/core/dom/Document.h:348: PassRefPtrWillBeRawPtr<NodeList> nodesFromRect(int centerX, int centerY, Dead code. https://codereview.chromium.org/334713006/diff/40001/Source/core/dom/Document.h#oldcode1159 Source/core/dom/Document.h:1159: ...
6 years, 6 months ago (2014-06-16 13:55:18 UTC) #1
adamk
https://codereview.chromium.org/334713006/diff/40001/Source/core/accessibility/AXTable.cpp File Source/core/accessibility/AXTable.cpp (right): https://codereview.chromium.org/334713006/diff/40001/Source/core/accessibility/AXTable.cpp#newcode142 Source/core/accessibility/AXTable.cpp:142: unsigned rowCount = rows->length(); Nit: this reads like over-optimizing ...
6 years, 6 months ago (2014-06-16 20:23:17 UTC) #2
Inactive
https://codereview.chromium.org/334713006/diff/40001/Source/core/accessibility/AXTable.cpp File Source/core/accessibility/AXTable.cpp (right): https://codereview.chromium.org/334713006/diff/40001/Source/core/accessibility/AXTable.cpp#newcode142 Source/core/accessibility/AXTable.cpp:142: unsigned rowCount = rows->length(); On 2014/06/16 20:23:17, adamk wrote: ...
6 years, 6 months ago (2014-06-16 20:35:51 UTC) #3
Inactive
+haraken/nbarth in case he has an opinion on how to fix the bindings build in ...
6 years, 6 months ago (2014-06-16 20:39:05 UTC) #4
haraken
On 2014/06/16 20:39:05, Chris Dumez wrote: > +haraken/nbarth in case he has an opinion on ...
6 years, 6 months ago (2014-06-17 01:40:20 UTC) #5
Inactive
On 2014/06/17 01:40:20, haraken wrote: > On 2014/06/16 20:39:05, Chris Dumez wrote: > > +haraken/nbarth ...
6 years, 6 months ago (2014-06-17 13:37:35 UTC) #6
adamk
lgtm now that headers in core/ are unaffected.
6 years, 6 months ago (2014-06-17 18:03:07 UTC) #7
haraken
LGTM for bindings/
6 years, 6 months ago (2014-06-17 23:37:24 UTC) #8
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-18 02:03:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/334713006/80001
6 years, 6 months ago (2014-06-18 02:04:15 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 02:04:33 UTC) #11
commit-bot: I haz the power
Failed to apply patch for Source/core/inspector/InspectorCSSAgent.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-18 02:04:35 UTC) #12
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-18 12:39:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/334713006/100001
6 years, 6 months ago (2014-06-18 12:40:47 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 14:43:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18663)
6 years, 6 months ago (2014-06-18 14:43:58 UTC) #16
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-18 14:46:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/334713006/100001
6 years, 6 months ago (2014-06-18 14:47:51 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 15:51:05 UTC) #19
Message was sent while issue was closed.
Change committed as 176427

Powered by Google App Engine
This is Rietveld 408576698