Use stricter typing for NodeLists throughout the code base

Source/core/html/HTMLTableElement.h

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef HTMLTableElement_h
 #define HTMLTableElement_h
 
 #include "core/html/HTMLElement.h"
+#include "core/html/HTMLTableRowsCollection.h"

[adamk, 2014/06/16 20:23:17]

Again interested why the include was needed. Perhaps you can just give an
overview of all those changes? (not going to comment on any more #include
changes)

[Inactive, 2014/06/16 20:35:51]

Same reason. The V8TableElement.cpp wouldn't build otherwise for the reasons
explained earlier. I don't know of a better solution at the moment.
Alternatively I could add an additional IDL extended attribute, or add a
specific rowsForBindings() method that returns an HTMLCollection.

 
 namespace WebCore {
 
 class ExceptionState;
 class HTMLCollection;
 class HTMLTableCaptionElement;
-class HTMLTableRowsCollection;
 class HTMLTableSectionElement;
 
 class HTMLTableElement FINAL : public HTMLElement {
 public:
     DECLARE_NODE_FACTORY(HTMLTableElement);
 
     HTMLTableCaptionElement* caption() const;
     void setCaption(PassRefPtrWillBeRawPtr<HTMLTableCaptionElement>, ExceptionState&);
 
     HTMLTableSectionElement* tHead() const;
     void setTHead(PassRefPtrWillBeRawPtr<HTMLTableSectionElement>, ExceptionState&);
 
     HTMLTableSectionElement* tFoot() const;
     void setTFoot(PassRefPtrWillBeRawPtr<HTMLTableSectionElement>, ExceptionState&);
 
     PassRefPtrWillBeRawPtr<HTMLElement> createTHead();
     void deleteTHead();
     PassRefPtrWillBeRawPtr<HTMLElement> createTFoot();
     void deleteTFoot();
     PassRefPtrWillBeRawPtr<HTMLElement> createTBody();
     PassRefPtrWillBeRawPtr<HTMLElement> createCaption();
     void deleteCaption();
     PassRefPtrWillBeRawPtr<HTMLElement> insertRow(ExceptionState&);
     PassRefPtrWillBeRawPtr<HTMLElement> insertRow(int index, ExceptionState&);
     void deleteRow(int index, ExceptionState&);
 
-    PassRefPtrWillBeRawPtr<HTMLCollection> rows();
+    PassRefPtrWillBeRawPtr<HTMLTableRowsCollection> rows();
     PassRefPtrWillBeRawPtr<HTMLCollection> tBodies();
 
     const AtomicString& rules() const;
     const AtomicString& summary() const;
 
     const StylePropertySet* additionalCellStyle();
     const StylePropertySet* additionalGroupStyle(bool rows);
 
     virtual void trace(Visitor*) OVERRIDE;
 
@@ skipping 27 matching lines @@
     TableRules m_rulesAttr;     // Implies a thin border width, a collapsing border model, and all borders on the table becoming set to hidden (if frame/border
                                 // are present, to none otherwise).
 
     unsigned short m_padding;
     RefPtrWillBeMember<StylePropertySet> m_sharedCellStyle;
 };
 
 } //namespace
 
 #endif