Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 334633003: Fix a crash during installing an extension with shared modules. (Closed)

Created:
6 years, 6 months ago by Peng
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, elijahtaylor1
Base URL:
https://chromium.googlesource.com/chromium/src.git@compositor_api_impl_new_1
Visibility:
Public.

Description

Fix a crash during installing an extension with shared modules. BUG=383310 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Peng
Hi Antony, PTAL. Thanks.
6 years, 6 months ago (2014-06-12 15:21:51 UTC) #1
asargent_no_longer_on_chrome
lgtm
6 years, 6 months ago (2014-06-12 19:43:21 UTC) #2
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 6 months ago (2014-06-12 19:44:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/334633003/1
6 years, 6 months ago (2014-06-12 19:46:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 01:16:51 UTC) #5
Message was sent while issue was closed.
Change committed as 276876

Powered by Google App Engine
This is Rietveld 408576698