chrome/browser/extensions/webstore_installer.cc - Issue 334633003: Fix a crash during installing an extension with shared modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 334633003: Fix a crash during installing an extension with shared modules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compositor_api_impl_new_1

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 7dd6017a7fdee54983652a08dc1ff3dee65eaaf5..f9ee93d724ea04005897b3ed5f39ea120a05de79 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -492,7 +492,9 @@ void WebstoreInstaller::OnDownloadStarted(

}

void WebstoreInstaller::OnDownloadUpdated(DownloadItem* download) {

- CHECK_EQ(download_item_, download);

+ // DownloadItemImpl calls the observer for a completed item, ignore it.

+ if (download_item_ != download)

+ return;

switch (download->GetState()) {

case DownloadItem::CANCELLED:

« no previous file with comments | « no previous file | no next file » | no next file with comments »