Issue 334613004: Revert 276642 "Turn FaviconClient into a Keyed service."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334613004: Revert 276642 "Turn FaviconClient into a Keyed service." (Closed)

Created:
6 years, 6 months ago by zhaoqin

Modified:
6 years, 6 months ago

Reviewers:
jif, jif-google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 276642 "Turn FaviconClient into a Keyed service." > Turn FaviconClient into a Keyed service. > > This is an intermediary CL. > The end goal is having the FaviconServiceFactory be able to obtain a FaviconClient to pass it to the FaviconService's constructor. > > BUG=377505 > > Review URL: https://codereview.chromium.org/301613004 TBR=jif@chromium.org BUG=383952 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276743

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -103 lines)			Patch
D	trunk/src/chrome/browser/favicon/chrome_favicon_client_factory.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	trunk/src/chrome/browser/favicon/chrome_favicon_client_factory.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	trunk/src/chrome/browser/favicon/favicon_tab_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/favicon/favicon_tab_helper.cc	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/components/favicon.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/components/favicon/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/components/favicon/core/browser/favicon_client.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

jif-google

6 years, 6 months ago (2014-06-13 08:20:54 UTC) #3

Message was sent while issue was closed.

On 2014/06/12 18:17:32, zhaoqin wrote:
> Committed patchset #1 manually as r276743.

LGTM