Turn FaviconClient into a Keyed service.

Turn FaviconClient into a Keyed service.

This is an intermediary CL.
The end goal is having the FaviconServiceFactory be able to obtain a FaviconClient to pass it to the FaviconService's constructor.

BUG=377505
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276642

[jif, 2014-05-27 09:02:52]

PTAL

[blundell, 2014-05-27 09:35:08]

LGTM

Add a little more context to the CL description, please, including some
information about the next step (passing the client in to FaviconService at
FaviconService construction?).

https://codereview.chromium.org/301613004/diff/20001/chrome/browser/favicon/c...
File chrome/browser/favicon/chrome_favicon_client_factory.cc (right):

https://codereview.chromium.org/301613004/diff/20001/chrome/browser/favicon/c...
chrome/browser/favicon/chrome_favicon_client_factory.cc:33: new
ChromeFaviconClient(static_cast<Profile*>(context));
nit: use Profile::FromBrowserContext(context).

[jif-google, 2014-05-27 15:02:07]

thanks.

https://codereview.chromium.org/301613004/diff/20001/chrome/browser/favicon/c...
File chrome/browser/favicon/chrome_favicon_client_factory.cc (right):

https://codereview.chromium.org/301613004/diff/20001/chrome/browser/favicon/c...
chrome/browser/favicon/chrome_favicon_client_factory.cc:33: new
ChromeFaviconClient(static_cast<Profile*>(context));
On 2014/05/27 09:35:08, blundell wrote:
> nit: use Profile::FromBrowserContext(context).

Done.

[jif, 2014-05-27 15:06:46]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-05-27 15:07:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/40001

[commit-bot: I haz the power, 2014-05-27 19:03:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-27 20:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:14:23]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jif-google, 2014-05-28 01:10:08]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-05-28 01:11:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/40001

[commit-bot: I haz the power, 2014-05-28 04:58:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 06:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 06:09:15]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jif, 2014-05-28 08:36:58]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-05-28 08:37:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/40001

[jif, 2014-05-28 11:48:19]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-05-28 11:49:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/60001

[commit-bot: I haz the power, 2014-05-28 13:37:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-28 13:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 13:48:10]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[jif, 2014-06-10 15:14:03]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-06-10 15:16:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/60001

[commit-bot: I haz the power, 2014-06-10 16:33:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-10 17:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 17:45:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[jif-google, 2014-06-11 08:07:29]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-06-11 08:10:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/60001

[commit-bot: I haz the power, 2014-06-11 09:39:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-11 10:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 10:58:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[jif-google, 2014-06-11 14:58:20]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-06-11 15:00:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/80001

[jif-google, 2014-06-11 16:33:39]

+skuhne for OWNER of chrome/browser/ui/ash/launcher

[Mr4D (OOO till 08-26), 2014-06-11 17:15:00]

lgtm

[jif-google, 2014-06-11 17:18:52]

The CQ bit was unchecked by jif@google.com

[jif-google, 2014-06-11 17:18:53]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-06-11 17:22:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/80001

[commit-bot: I haz the power, 2014-06-11 21:00:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:14:50]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jif-google, 2014-06-12 07:04:42]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-06-12 07:06:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/301613004/80001

[commit-bot: I haz the power, 2014-06-12 12:43:34]

Change committed as 276642