Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 3346005: Don't create pending entries when a navigation is initiated by the page. (Closed)

Created:
8 years, 5 months ago by Jay Civelli
Modified:
7 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Relanding this: Don't create pending entries when a navigation is initiated by the page. If the page reloads while such a navigation happens, we could end up with the wrong pending entry. Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH. BUG=51680 TEST=See bug for steps. TBR=creis Review URL: http://codereview.chromium.org/3257002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58261 0039d316-1c4b-4281-b951-d872f2087c98 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -93 lines) Patch
M chrome/browser/back_forward_menu_model_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 4 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/test_tab_contents.h View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/test_tab_contents.cc View 2 chunks +31 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 53 chunks +54 lines, -68 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698