Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.h

Issue 3346005: Don't create pending entries when a navigation is initiated by the page. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
7 #pragma once 7 #pragma once
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 // Saves the given title to the navigation entry and does associated work. It 811 // Saves the given title to the navigation entry and does associated work. It
812 // will update history and the view for the new title, and also synthesize 812 // will update history and the view for the new title, and also synthesize
813 // titles for file URLs that have none (so we require that the URL of the 813 // titles for file URLs that have none (so we require that the URL of the
814 // entry already be set). 814 // entry already be set).
815 // 815 //
816 // This is used as the backend for state updates, which include a new title, 816 // This is used as the backend for state updates, which include a new title,
817 // or the dedicated set title message. It returns true if the new title is 817 // or the dedicated set title message. It returns true if the new title is
818 // different and was therefore updated. 818 // different and was therefore updated.
819 bool UpdateTitleForEntry(NavigationEntry* entry, const std::wstring& title); 819 bool UpdateTitleForEntry(NavigationEntry* entry, const std::wstring& title);
820 820
821 // Causes the TabContents to navigate in the right renderer to |entry|, which
822 // must be already part of the entries in the navigation controller.
823 // This does not change the NavigationController state.
824 bool NavigateToEntry(const NavigationEntry& entry,
825 NavigationController::ReloadType reload_type);
826
821 // Misc non-view stuff ------------------------------------------------------- 827 // Misc non-view stuff -------------------------------------------------------
822 828
823 // Helper functions for sending notifications. 829 // Helper functions for sending notifications.
824 void NotifySwapped(); 830 void NotifySwapped();
825 void NotifyConnected(); 831 void NotifyConnected();
826 void NotifyDisconnected(); 832 void NotifyDisconnected();
827 833
828 // If params has a searchable form, this tries to create a new keyword. 834 // If params has a searchable form, this tries to create a new keyword.
829 void GenerateKeywordIfNecessary( 835 void GenerateKeywordIfNecessary(
830 const ViewHostMsg_FrameNavigate_Params& params); 836 const ViewHostMsg_FrameNavigate_Params& params);
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
1263 bool displaying_pdf_content_; 1269 bool displaying_pdf_content_;
1264 1270
1265 scoped_ptr<MatchPreview> match_preview_; 1271 scoped_ptr<MatchPreview> match_preview_;
1266 1272
1267 // --------------------------------------------------------------------------- 1273 // ---------------------------------------------------------------------------
1268 1274
1269 DISALLOW_COPY_AND_ASSIGN(TabContents); 1275 DISALLOW_COPY_AND_ASSIGN(TabContents);
1270 }; 1276 };
1271 1277
1272 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 1278 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698