Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/hydrogen-instructions.h

Issue 334403003: MIPS: Fix big-endian after r21774/r21803. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8.h ('K') | « include/v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index f1720f444247d83635c84d00a99cf2457ee0022e..97ec1584ac896db245b6c7888b3f3f61c62847c3 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -6091,11 +6091,19 @@ class HObjectAccess V8_FINAL {
}
static HObjectAccess ForMapInstanceTypeAndBitField() {
+#if V8_TARGET_LITTLE_ENDIAN
STATIC_ASSERT((Map::kInstanceTypeOffset & 1) == 0);
STATIC_ASSERT(Map::kBitFieldOffset == Map::kInstanceTypeOffset + 1);
return HObjectAccess(kInobject,
Map::kInstanceTypeOffset,
Toon Verwaest 2014/06/17 16:50:01 Can we use Map::kInstanceTypeAndBitFieldOffset and
danno 2014/06/18 11:18:41 +1 to Toon's comment
Paul Lind 2014/06/19 07:31:22 Nice suggestion, Toon, it makes it cleaner, and en
Representation::UInteger16());
+#else
+ STATIC_ASSERT((Map::kBitFieldOffset & 1) == 0);
+ STATIC_ASSERT(Map::kInstanceTypeOffset == Map::kBitFieldOffset + 1);
+ return HObjectAccess(kInobject,
+ Map::kBitFieldOffset,
+ Representation::UInteger16());
+#endif
}
static HObjectAccess ForPropertyCellValue() {
« include/v8.h ('K') | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698