MIPS: Fix big-endian after r21774/r21803.

src/hydrogen-instructions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
 #define V8_HYDROGEN_INSTRUCTIONS_H_
 
 #include "src/v8.h"
 
 #include "src/allocation.h"
@@ skipping 6073 matching lines @@
                          Representation::UInteger8());
   }
 
   static HObjectAccess ForNameHashField() {
     return HObjectAccess(kInobject,
                          Name::kHashFieldOffset,
                          Representation::Integer32());
   }
 
   static HObjectAccess ForMapInstanceTypeAndBitField() {
+#if V8_TARGET_LITTLE_ENDIAN
     STATIC_ASSERT((Map::kInstanceTypeOffset & 1) == 0);
     STATIC_ASSERT(Map::kBitFieldOffset == Map::kInstanceTypeOffset + 1);
     return HObjectAccess(kInobject,
                          Map::kInstanceTypeOffset,

[Toon Verwaest, 2014/06/17 16:50:01]

Can we use Map::kInstanceTypeAndBitFieldOffset and define that based on
endianness?

[danno, 2014/06/18 11:18:41]

+1 to Toon's comment

[Paul Lind, 2014/06/19 07:31:22]

Nice suggestion, Toon, it makes it cleaner, and enables the above api cleanup as
well. Done.

                          Representation::UInteger16());
+#else
+    STATIC_ASSERT((Map::kBitFieldOffset & 1) == 0);
+    STATIC_ASSERT(Map::kInstanceTypeOffset == Map::kBitFieldOffset + 1);
+    return HObjectAccess(kInobject,
+                         Map::kBitFieldOffset,
+                         Representation::UInteger16());
+#endif
   }
 
   static HObjectAccess ForPropertyCellValue() {
     return HObjectAccess(kInobject, PropertyCell::kValueOffset);
   }
 
   static HObjectAccess ForCellValue() {
     return HObjectAccess(kInobject, Cell::kValueOffset);
   }
 
@@ skipping 1693 matching lines @@
 };
 
 
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_