Issue 334393004: DevTools: Always construct CodeMirror explicitly, via "new"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334393004: DevTools: Always construct CodeMirror explicitly, via "new" (Closed)

Created:
6 years, 6 months ago by apavlov

Modified:
6 years, 6 months ago

Reviewers:
lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Always construct CodeMirror explicitly, via "new" This patch also cleans up and fixes a bunch of codemirror-related externs R=lushnikov NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176332

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -14 lines)			Patch
M	Source/devtools/front_end/externs.js	View	9 chunks	+32 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/source_frame/CodeMirrorUtils.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/334393004/1

6 years, 6 months ago (2014-06-17 16:31:35 UTC) #4

Message was sent while issue was closed.

Change committed as 176332

Expand Messages | Collapse Messages