Source/devtools/front_end/source_frame/CodeMirrorUtils.js - Issue 334393004: DevTools: Always construct CodeMirror explicitly, via "new"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/source_frame/CodeMirrorUtils.js

Issue 334393004: DevTools: Always construct CodeMirror explicitly, via "new" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/source_frame/CodeMirrorUtils.js

diff --git a/Source/devtools/front_end/source_frame/CodeMirrorUtils.js b/Source/devtools/front_end/source_frame/CodeMirrorUtils.js

index 31d0eb49d2137562e458de1f51c5eb3bb7816e9c..c75be1c072cc4f8997873ab540583e34ad280d32 100644

--- a/Source/devtools/front_end/source_frame/CodeMirrorUtils.js

+++ b/Source/devtools/front_end/source_frame/CodeMirrorUtils.js

@@ -84,7 +84,7 @@ WebInspector.CodeMirrorUtils.prototype = {

editingContext.cssLoadView.show(element);

WebInspector.setCurrentFocusElement(element);

element.addEventListener("copy", this._consumeCopy, false);

- var codeMirror = window.CodeMirror(element, {

+ var codeMirror = new window.CodeMirror(element, {

mode: config.mode,

lineWrapping: config.lineWrapping,

smartIndent: config.smartIndent,

« no previous file with comments | « Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js ('k') | no next file » | no next file with comments »