Use nacl_secure_random() in rand_util_nacl.cc

Use nacl_secure_random() in rand_util_nacl.cc

The rand_util_nacl.cc will be used inside the IRT and outside the IRT.  So we need to use nacl_secure_random() which will work for both.

BUG=nativeclient:3881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277853

[Peng, 2014-06-16 23:31:54]

PTAL. Thanks.

[Mark Seaborn, 2014-06-16 23:39:25]

Please set BUG= to the NaCl issue you filed.

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc
File base/rand_util_nacl.cc (right):

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc#newco...
base/rand_util_nacl.cc:17: int rv = nacl_secure_random_init();
nacl_secure_random_init() is idempotent so you can actually simplify this by
just having a top-level function that does:

void GetRandomBytes(void* output, size_t num_bytes) {
  CHECK_EQ(0, nacl_secure_random_init());
  const int error = nacl_secure_random(...);
  ...
}

Then the use of LazyInstance can go away.

(I will simplify this on the NaCl side so that calling nacl_secure_random_init()
isn't needed at all.)

[Mark Seaborn, 2014-06-16 23:47:38]

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc
File base/rand_util_nacl.cc (right):

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc#newco...
base/rand_util_nacl.cc:10: #include
"native_client/src/untrusted/nacl/nacl_random.h"
I think it should work to #include this with:
#include <nacl/nacl_random.h>
Does that work?

[Peng, 2014-06-16 23:57:26]

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc
File base/rand_util_nacl.cc (right):

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc#newco...
base/rand_util_nacl.cc:10: #include
"native_client/src/untrusted/nacl/nacl_random.h"
On 2014/06/16 23:47:38, Mark Seaborn wrote:
> I think it should work to #include this with:
> #include <nacl/nacl_random.h>
> Does that work?

It works. Done

https://codereview.chromium.org/334353004/diff/1/base/rand_util_nacl.cc#newco...
base/rand_util_nacl.cc:17: int rv = nacl_secure_random_init();
On 2014/06/16 23:39:25, Mark Seaborn wrote:
> nacl_secure_random_init() is idempotent so you can actually simplify this by
> just having a top-level function that does:
> 
> void GetRandomBytes(void* output, size_t num_bytes) {
>   CHECK_EQ(0, nacl_secure_random_init());
>   const int error = nacl_secure_random(...);
>   ...
> }
> 
> Then the use of LazyInstance can go away.
> 
> (I will simplify this on the NaCl side so that calling
nacl_secure_random_init()
> isn't needed at all.)

Done.

[Mark Seaborn, 2014-06-17 00:07:10]

LGTM, thanks

[Peng, 2014-06-17 18:11:56]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2014-06-17 18:13:02]

The CQ bit was unchecked by penghuang@chromium.org

[Mark Mentovai, 2014-06-17 18:19:57]

LGTM

[Peng, 2014-06-17 18:26:49]

On 2014/06/17 18:19:57, Mark Mentovai wrote:
> LGTM

Thanks for review.

[Peng, 2014-06-17 18:26:55]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2014-06-17 18:29:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/penghuang@chromium.org/334353004/40001

[commit-bot: I haz the power, 2014-06-17 20:28:50]

Change committed as 277853