Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: base/rand_util_nacl.cc

Issue 334353004: Use nacl_secure_random() in rand_util_nacl.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review issues Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/rand_util.h" 5 #include "base/rand_util.h"
6 6
7 #include <nacl/nacl_random.h>
8
7 #include "base/basictypes.h" 9 #include "base/basictypes.h"
8 #include "base/lazy_instance.h"
9 #include "base/logging.h" 10 #include "base/logging.h"
10 #include "native_client/src/untrusted/irt/irt.h"
11 11
12 namespace { 12 namespace {
13 13
14 class NaclRandom { 14 void GetRandomBytes(void* output, size_t num_bytes) {
15 public: 15 CHECK_EQ(0, nacl_secure_random_init());
16 NaclRandom() { 16 char* output_ptr = static_cast<char*>(output);
17 const size_t result = 17 while (num_bytes > 0) {
18 nacl_interface_query(NACL_IRT_RANDOM_v0_1, &random_, sizeof(random_)); 18 size_t nread;
19 CHECK_EQ(result, sizeof(random_)); 19 const int error = nacl_secure_random(output_ptr, num_bytes, &nread);
20 CHECK_EQ(error, 0);
21 CHECK_LE(nread, num_bytes);
22 output_ptr += nread;
23 num_bytes -= nread;
20 } 24 }
21 25 }
22 ~NaclRandom() {}
23
24 void GetRandomBytes(void* output, size_t num_bytes) {
25 char* output_ptr = static_cast<char*>(output);
26 while (num_bytes > 0) {
27 size_t nread;
28 const int error = random_.get_random_bytes(output_ptr, num_bytes, &nread);
29 CHECK_EQ(error, 0);
30 CHECK_LE(nread, num_bytes);
31 output_ptr += nread;
32 num_bytes -= nread;
33 }
34 }
35
36 private:
37 nacl_irt_random random_;
38 };
39
40 base::LazyInstance<NaclRandom>::Leaky g_nacl_random = LAZY_INSTANCE_INITIALIZER;
41 26
42 } // namespace 27 } // namespace
43 28
44 namespace base { 29 namespace base {
45 30
46 // NOTE: This function must be cryptographically secure. http://crbug.com/140076 31 // NOTE: This function must be cryptographically secure. http://crbug.com/140076
47 uint64 RandUint64() { 32 uint64 RandUint64() {
48 uint64 result; 33 uint64 result;
49 g_nacl_random.Pointer()->GetRandomBytes(&result, sizeof(result)); 34 GetRandomBytes(&result, sizeof(result));
50 return result; 35 return result;
51 } 36 }
52 37
53 void RandBytes(void* output, size_t output_length) { 38 void RandBytes(void* output, size_t output_length) {
54 g_nacl_random.Pointer()->GetRandomBytes(output, output_length); 39 GetRandomBytes(output, output_length);
55 } 40 }
56 41
57 } // namespace base 42 } // namespace base
OLDNEW
« no previous file with comments | « base/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698